Repository navigation
feat: Windows XP build (xp feature) - #677
Merged
Merged
Conversation
sysinfo takes the major version of Windows from CurrentMajorVersionNumber,
which only exists since Windows 10, so Windows 8.1, 7 and XP came out as
"Windows 0 (2600)". When that happens, the product name from the registry
is used instead ("Microsoft Windows XP (2600)").
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
`cargo build --release --target i686-pc-windows-msvc --no-default-features --features xp` builds a binary for Windows XP: - VC-LTL5 and YY-Thunks are linked through thunk-rs (curl and 7z are needed unless VC_LTL and YY_THUNKS point at them) - TLS goes through rustls with ring and the bundled Mozilla roots, since XP has no usable TLS stack and an outdated root store; the updater uses ureq, since reqwest's rustls needs aws-lc-rs and the system roots Other builds keep native-tls, now behind the default native-tls feature. CI builds the XP binary as i686-pc-windows-msvc. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
ありがとうございます。中身は良さそうなのでマージします。気になった点を1つだけ書いておきます（こちらで別の PR で対応します）。 ビルド時のダウンロードが検証されていない thunk-rs 0.3.5 は VC-LTL5 と YY-Thunks を
CI では自分でダウンロードして SHA-256 を確かめ、 あと、#676 で接続にタイムアウトを付けたときに |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
xpfeature）cargo build --release --target i686-pc-windows-msvc --no-default-features --features xpVC_LTL/YY_THUNKSが無ければ curl と 7z でダウンロード）subsystem_windows）native-tlsfeature に移動）。xpと同時に有効にするとコンパイルエラーi686-pc-windows-msvcを--no-default-features --features xpでビルドし、リリースにも上げるWindows 0 (2600)になるのを修正。sysinfo がメジャーバージョンを Windows 10 以降にしかないCurrentMajorVersionNumberから読むため。この場合はレジストリのProductNameを使う（例:Microsoft Windows XP (2600)）確認
advapi32!SystemFunction036、Vista 以降の API の直接インポートなし🤖 Generated with Claude Code